sciactive/nephele

Resolve promise to avoid hang when handling files #7

Merged

FROGGS merged 1 commit from patch-1 into master

2024-10-12 10:32:50 -07:00

FROGGS commented

2024-10-12 09:23:18 -07:00

(Migrated from github.com)

Returning inside a Promise does not resolve said Promise. The calling code will hang forever. This can easily be demostrated by using die virtual adapter with diretories and with and without a file entry. As soon as there is a file entry, it hangs. Resolving the promise solves this bug.

Returning inside a Promise does not resolve said Promise. The calling code will hang forever. This can easily be demostrated by using die virtual adapter with diretories and with and without a file entry. As soon as there is a file entry, it hangs. Resolving the promise solves this bug.

hperrin commented

2024-10-12 10:33:04 -07:00

(Migrated from github.com)

Thank you for the fix!

Thank you for the fix!

hperrin commented

2024-10-12 10:43:53 -07:00

(Migrated from github.com)

Released as 1.0.0-alpha.59

Released as 1.0.0-alpha.59

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

sciactive/nephele!7

No description provided.