Fix audio pauses #15

2018-07-03T01:41:39-07:00

HillaFPV commented

2018-07-03 01:41:39 -07:00

(Migrated from github.com)

This will resolve the audio skips by rendering a separate audio-only track on a single thread, then joining that to the usual output of pulverize with ffmpeg.

This also allows use of code in pulverize_tools in a programmatic way, so interfacing with blender is a bit easier.

This will resolve the audio skips by rendering a separate audio-only track on a single thread, then joining that to the usual output of pulverize with ffmpeg. This also allows use of code in pulverize_tools in a programmatic way, so interfacing with blender is a bit easier.

🎉 1

FraYoshi (Migrated from github.com) reviewed

2018-07-03 09:20:35 -07:00

pulverize_tool.py

					
				@ -6,0 +11,4 @@

				    sed = scene.sequence_editor

				    sequences = sed.sequences_all

				    for strip in sequences:

any reason for choosing flac over pcm? :)

HillaFPV (Migrated from github.com) reviewed

2018-07-03 09:27:31 -07:00

pulverize_tool.py

					
				@ -6,0 +11,4 @@

				    sed = scene.sequence_editor

				    sequences = sed.sequences_all

				    for strip in sequences:

Just as lossless, smaller temporary file size, and it gets in encoded as AAC in the final step anyway.

NathanLovato commented

2018-07-03 18:32:15 -07:00

(Migrated from github.com)

Hey there! We branched pulverize and started improving it on https://github.com/GDquest/Blender-power-sequencer/blob/multithreaded-render-script/scripts/render_video_multithreaded.py. The script wouldn't run for me and the repo looked idle, plus we wanted to integrate a rendering tool to the add-on directly - can't use this repo as a git submodule.

I've already modified the code on the fork so can't add this PR as-is, but do you mind if we integrate your changes? We have a similar issue here: https://github.com/GDquest/Blender-power-sequencer/issues/148

Hey there! We branched pulverize and started improving it on https://github.com/GDquest/Blender-power-sequencer/blob/multithreaded-render-script/scripts/render_video_multithreaded.py. The script wouldn't run for me and the repo looked idle, plus we wanted to integrate a rendering tool to the add-on directly - can't use this repo as a git submodule. I've already modified the code on the fork so can't add this PR as-is, but do you mind if we integrate your changes? We have a similar issue here: https://github.com/GDquest/Blender-power-sequencer/issues/148

HillaFPV commented

2018-07-03 21:27:38 -07:00

(Migrated from github.com)

Go right ahead. I'd be happy to integrate the changes into your repo and send a PR if you'd like.

NathanLovato commented

2018-07-03 23:09:10 -07:00

(Migrated from github.com)

Would definitely be much appreciated! I was about to implement something similar this week. I'll be there to review and merge as soon as it's up :)

Ping @sudopluto, may be worth waiting for this to be in before doing the cleanup pass?

Would definitely be much appreciated! I was about to implement something similar this week. I'll be there to review and merge as soon as it's up :) Ping @sudopluto, may be worth waiting for this to be in before doing the cleanup pass?

NathanLovato commented

2018-07-12 22:50:49 -07:00

(Migrated from github.com)

@ceefit We've gone ahead and re-written the code to make it more maintainable. We had to fix a few things along the way, so we went ahead and added the mixdown rendering function directly! The script is in its own folder now (and it'll likely get broken down a little more soon): https://github.com/GDquest/Blender-power-sequencer/tree/master/scripts/multithreaded_render

hperrin commented

2018-07-20 14:23:45 -07:00

(Migrated from github.com)

I take it this doesn't work with the PHP version of the script, right?

hperrin commented

2018-07-20 14:26:37 -07:00

(Migrated from github.com)

Btw, I'm really glad to see more work in the Blender VSE community. :D It's such an awesome tool.

NathanLovato commented

2018-07-20 17:02:25 -07:00

(Migrated from github.com)

A quick note: we already added this to the multithreaded renderer in power sequencer. There's only keyboard interrupt support missing on the windows shell now (you've got to kill the process manually with powershell at the moment), but at least compared to pulverize.py it should run on all platforms.