fix: for windows users #1

Merged

Zielak merged 1 commit from master into master

2022-01-10 09:28:19 -08:00

Zielak commented

2022-01-10 09:03:04 -08:00

(Migrated from github.com)

Hello there! Hopefully you're open to PR with fixes :)

glob outputs filepaths with / separators, regardless of platform its run on and it doesn't look like they're going to change that. On windows this makes svelte-strip output files starting from top of the drive, instead of repository's directory.

Running svelte-strip strip src/ dist/ and added some console logs to inspect it:

Before fix:

// glob's result:
files: [
  'E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte',
   ...
]

// in loop, for single file:
        sep:     \
        inpath:  E:\dev\repo\packages\clientCommons\src
        infile:  E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte
        slice:   /components/CardSuits.svelte
        outfile: E:\components\CardSuits.svelte

// In functions:
makeDirectoryStructure( E:\components\CardSuits.svelte )
strip( E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte, E:\components\CardSuits.svelte, true )

After fix:

// glob's result manipulated:
files: [
  'E:\\dev\\repo\\packages\\clientCommons\\src\\components\\CardSuits.svelte',
...
]

// in loop, for single file:
        sep:     \
        inpath:  E:\dev\repo\packages\clientCommons\src
        infile:  E:\dev\repo\packages\clientCommons\src\components\CardSuits.svelte
        slice:   \components\CardSuits.svelte
        outfile: E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte

// In functions:
makeDirectoryStructure( E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte )
strip( E:\dev\repo\packages\clientCommons\src\components\CardSuits.svelte, E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte, true )

I've left out console logs in my windows-fix branch

Hello there! Hopefully you're open to PR with fixes :) glob outputs filepaths with `/` separators, regardless of platform its run on and [it doesn't look like they're going to change that](https://github.com/isaacs/node-glob#windows). On windows this makes `svelte-strip` output files starting from top of the drive, instead of repository's directory. Running `svelte-strip strip src/ dist/` and added some console logs to inspect it: ### Before fix: ``` // glob's result: files: [ 'E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte', ... ] // in loop, for single file: sep: \ inpath: E:\dev\repo\packages\clientCommons\src infile: E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte slice: /components/CardSuits.svelte outfile: E:\components\CardSuits.svelte // In functions: makeDirectoryStructure( E:\components\CardSuits.svelte ) strip( E:/dev/repo/packages/clientCommons/src/components/CardSuits.svelte, E:\components\CardSuits.svelte, true ) ``` ### After fix: ``` // glob's result manipulated: files: [ 'E:\\dev\\repo\\packages\\clientCommons\\src\\components\\CardSuits.svelte', ... ] // in loop, for single file: sep: \ inpath: E:\dev\repo\packages\clientCommons\src infile: E:\dev\repo\packages\clientCommons\src\components\CardSuits.svelte slice: \components\CardSuits.svelte outfile: E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte // In functions: makeDirectoryStructure( E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte ) strip( E:\dev\repo\packages\clientCommons\src\components\CardSuits.svelte, E:\dev\repo\packages\clientCommons\dist\components\CardSuits.svelte, true ) ``` I've left out console logs in my [windows-fix branch](https://github.com/Zielak/svelte-strip/tree/windows-fix)

hperrin commented

2022-01-10 09:28:28 -08:00

(Migrated from github.com)

Thanks for the fix!

hperrin commented

2022-01-10 09:33:06 -08:00

(Migrated from github.com)

Released as 1.0.1!

🎉 1